[Differential] [Request, 32 lines] D4465: Fix i18n extraction in Kickoff Buttons
David Edmundson
noreply at phabricator.kde.org
Mon Feb 6 16:42:45 UTC 2017
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The current code returns a string containing an array of properties.
This breaks i18n extraction as i18n() inside another string won't work.
This patch returns properties as an object so that i18n translation
works.
The config is also changed so that extraction works properly.
BUG: 375880
TEST PLAN
Kickoff loads as before
No i18n is nested in a string
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4465
AFFECTED FILES
applets/kickoff/package/contents/ui/ConfigButtons.qml
applets/kickoff/package/contents/ui/FullRepresentation.qml
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170206/6cdb8375/attachment.html>
More information about the Plasma-devel
mailing list