[Differential] [Changed Subscribers] D1989: Introduce QQuickItem to nest kwin_wayland

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> kwinqml.cpp:44
> +    : QQuickItem(parent)
> +    , m_timeSinceStart(new QElapsedTimer)
> +{

this timer doesn't do anything, it's not started.

> kwinqml.cpp:131
> +    m_texture = nullptr;
> +    m_texture = window()->createTextureFromImage(m_surface->buffer()->data());
> +    n->setTexture(m_texture);

This texture leaks when this item is destroyed

> kwinqml.cpp:170
> +    if (m_seat != nullptr) {
> +        m_seat->setPointerPos(event->pos());
> +    }

you also want:

  m_seat->setTimestamp(event->timestamp());

in all of these

and there's a wheelEvent(QWheelEvent*) that should be forwarded.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D1989

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, bshah, graesslin, #plasma_on_wayland
Cc: davidedmundson, bshah, graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170206/91d5fc32/attachment-0001.html>