[Differential] [Request, 4 lines] D4394: Fix potential crash in KCmFontInst on invalid index

David Edmundson noreply at phabricator.kde.org
Wed Feb 1 13:43:23 UTC 2017


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  If !index.isValid() grp remains null and any use of it will crash.
  
  There is a check for that, but then there's code relying on grp being
  valid both before and after that check.

TEST PLAN
  Compiles

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4394

AFFECTED FILES
  kcms/kfontinst/kcmfontinst/KCmFontInst.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170201/c6eeefac/attachment-0001.html>


More information about the Plasma-devel mailing list