[Differential] [Request, 36 lines] D4387: Ensure the layoutChanged DBus signal gets emitted when changing layouts through DBus
Martin Gräßlin
noreply at phabricator.kde.org
Wed Feb 1 06:08:20 UTC 2017
graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.
REVISION SUMMARY
Unfortunately Xkb does not emit a signal when the keyboard layout
changes. Due to that we need to manually check in KeyboardLayout after
each action which could change the layout whether the layout changed.
This was not yet done for the case when the layout got changed through
the DBus interface. Resulting in the DBus signal not emitted.
This change addresses the issue by invoking the check for change after
changing the keyboard layout.
TEST PLAN
Added test case
REPOSITORY
R108 KWin
BRANCH
fix-layout-changed-signal-dbus
REVISION DETAIL
https://phabricator.kde.org/D4387
AFFECTED FILES
autotests/integration/keyboard_layout_test.cpp
keyboard_layout.cpp
keyboard_layout.h
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170201/9d0ebf04/attachment.html>
More information about the Plasma-devel
mailing list