D9542: Improve display of technical app info

[Alexey Min]

alexeymin added a comment.


  "After" definitely looks better :)

INLINE COMMENTS

> ApplicationPage.qml:153
>              Layout.fillWidth: true
> -            text: appInfo.application.comment
> +            Text {
> +                text: appInfo.application.comment

Why do you put a `Text` inside a label? Why not use `font.bold` property of Label itself?

> ApplicationPage.qml:166
> +            columns: 2
>              Layout.fillWidth: true
> +

Does `Layout.fillWidth` have an effect here? Shouldn't it be inside of QQC2.Label block?

> ApplicationPage.qml:189
> +                elide: Text.ElideRight
> +                text: version ? i18n("%1", version) : ""
> +            }

Translation is probably not needed here now

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D9542

To: ngraham, apol, #vdg, #discover_software_store
Cc: alexeymin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171229/62499804/attachment.html>