D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"
Fabian Vogt
noreply at phabricator.kde.org
Fri Dec 22 13:37:16 UTC 2017
fvogt added a comment.
In https://phabricator.kde.org/D9473#182454, @anthonyfieroni wrote:
> Deletion is needed
> https://phabricator.kde.org/source/knewstuff/browse/master/src/downloaddialog.cpp;6de0754aa9258558a7203afc366b49984f0192eb$112
> https://phabricator.kde.org/source/knewstuff/browse/master/src/downloaddialog.cpp;6de0754aa9258558a7203afc366b49984f0192eb$50
> https://phabricator.kde.org/source/knewstuff/browse/master/src/downloadwidget.cpp;6de0754aa9258558a7203afc366b49984f0192eb$69
> https://phabricator.kde.org/source/knewstuff/browse/master/src/downloadwidget.cpp;6de0754aa9258558a7203afc366b49984f0192eb$121
> https://phabricator.kde.org/source/knewstuff/browse/master/src/core/engine.cpp;6de0754aa9258558a7203afc366b49984f0192eb$107
> Save this cache to disk, otherwise not saving anything since dialog just leak.
Then the dialog should be destroyed on close or KNS3 needs to save the cache more often.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9473
To: fvogt, #plasma, davidedmundson, anthonyfieroni
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171222/d5b7ccb1/attachment.html>
More information about the Plasma-devel
mailing list