D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"

Fabian Vogt noreply at phabricator.kde.org
Fri Dec 22 09:13:31 UTC 2017


fvogt created this revision.
fvogt added reviewers: Plasma, davidedmundson, anthonyfieroni.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  This reverts commit https://phabricator.kde.org/R120:84a29ef86380fab40236bdf934b49bc3cf090853.
  
  WidgetExplorer gets destroyed immediately the containment is closed, so
  the dialog is immediately deleted. The bug the patch was supposed to fix
  is totally unrelated to this, as according to the report a restart of
  plasmashell does not help.

TEST PLAN
  Not tested, but setting a breakpoint on the dialog's destructor
  points to this change.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.11

REVISION DETAIL
  https://phabricator.kde.org/D9473

AFFECTED FILES
  components/shellprivate/widgetexplorer/widgetexplorer.cpp

To: fvogt, #plasma, davidedmundson, anthonyfieroni
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171222/0f1aacd1/attachment.html>


More information about the Plasma-devel mailing list