D9422: [Connection Item] Use QtQuick's built-in HSV color features for cycling download color
Kai Uwe Broulik
noreply at phabricator.kde.org
Wed Dec 20 09:13:58 UTC 2017
broulik created this revision.
broulik added reviewers: Plasma, jgrulich.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
TEST PLAN
`Qt.hsva` was added in Qt 5.5 and the `hsvHue` stuff was merged in July 2016, so should be fine to use now.
Color looks the same as before. Value needs to be `[0,1]` hence the `+0.5` and modulo. I tried just `+=`'ing `hsvHue` but that didn't work.
Btw, isn't that just inverting the color? ie. we could just 1-r, 1-g, 1-b the color?
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D9422
AFFECTED FILES
applet/contents/ui/ConnectionItem.qml
To: broulik, #plasma, jgrulich
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171220/b066d8d4/attachment.html>
More information about the Plasma-devel
mailing list