D9352: [libcolorcorrect] Send auto location updates only when desirable

[Roman Gilg]

romangg created this revision.
romangg added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Instead of always sending auto location updates through our daemon query the current running and mode states of KWin and only send it when running is true and mode is zero, i.e. automatic location and time updates.
  
  This is primarily meant as an improvement for deployments in sensitive operation areas, where connections to external sources (even like in our case anonymously via mozilla location service or if available gps)  might be unwanted.
  
  Another future improvement might be to only launch the daemon on demand, i.e. let KWin ask for this via dbus through KDED's functionality when automatic mode is activated (either at startup or per config change).

TEST PLAN
  Manually with and without automatic location updates. I failed writing an autotest because of KDED and DataEngine internals, where I was not able to mock most of this external functionality (it compiled but on executing it still tried to use the external libs for some reason, which gave memory corruptions). Just using the external libs lead to non-meaningful results because it was at no point using the available internet connection in the test. If somebody has a tip how I could make this work I'll gladly rewrite my autotest attempt.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9352

AFFECTED FILES
  libcolorcorrect/compositorcoloradaptor.cpp
  libcolorcorrect/compositorcoloradaptor.h
  libcolorcorrect/kded/locationupdater.cpp
  libcolorcorrect/kded/locationupdater.h

To: romangg, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171215/fc0219f4/attachment.html>