D9323: Use ScreenMapper everywhere as a singleton

Andras Mantia noreply at phabricator.kde.org
Thu Dec 14 11:11:18 UTC 2017


amantia added inline comments.

INLINE COMMENTS

> broulik wrote in foldermodel.cpp:124
> Why have this member then?

For convenience

> broulik wrote in foldermodel.cpp:194
> I think we shouldn't connect to the signals if we're not a containment?

Yes, that makes sense, I will fix it

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9323

To: amantia, #plasma, mwolff, hein
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171214/6441f659/attachment.html>


More information about the Plasma-devel mailing list