D9276: highlight PlasmaComponents3.ComboBox list items

[Marco Martin]

mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ComboBox.qml:49
> +
> +        background: Rectangle{
> +            width: itemDelegate.width

uuh, no, ItemDelegate should highlight by itself when hovered without having to do that, this would say that there is a problem in ItemDelegate?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9276

To: mvourlakos, #plasma, mart
Cc: mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171214/8d824002/attachment.html>