D9271: Fixed memory leak in new_argv

Anthony Fieroni noreply at phabricator.kde.org
Wed Dec 13 05:21:43 UTC 2017


anthonyfieroni added inline comments.

INLINE COMMENTS

> Viewer.cpp:143
>                      viewer=new KFI::CViewer;
>                      viewer->show();
>                  }

You should set attribute delete on close as well.

> standard_actions_module.cpp:136
>      m_editor->addCollection(m_actionCollection, i18n("Standard Shortcuts"));
> +
>      }

unrelated

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9271

To: nathanhenry, davidedmundson
Cc: anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171213/738e0c9e/attachment-0001.html>


More information about the Plasma-devel mailing list