D9215: Make Appmenu work based on the presence of a visual representation

[Marco Martin]

mart marked an inline comment as done.
mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in appmenuapplet.cpp:60
> I don't understand what this else clause is about

it registers or unregisters the service when the destroyed value of the applet change, and not in the dtor, because:
when we "delete" an applet, it just hides it for about a minute setting its status to destroyed, in order to be able to do a clean undo: if we undo, there will be another destroyedchanged and destroyed will be false.
When this happens, if we are the only appmenu applet existing, the dbus interface will have to be registered again

> davidedmundson wrote in appmenu.cpp:208
> why?

leftover, can be killed

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9215

To: mart, #plasma
Cc: davidedmundson, ngraham, mvourlakos, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171212/d0af3834/attachment.html>