D9215: Make Appmenu work based on the presence of a visual representation

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> appmenuapplet.cpp:60
> +            //if we're the first, regster the service
> +            if (++s_refs == 1) {
> +                QDBusConnection::sessionBus().interface()->registerService(s_viewService,

I don't understand what this else clause is about

> appmenu.cpp:205
>  
> -// reload settings
> +// this method is not really used anymore but has tobe keot for DBus compatibility
>  void AppMenuModule::reconfigure()

typos

> appmenu.cpp:208
>  {
>      hideMenu(); // hide window decoration menu if exists
>  }

why?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9215

To: mart, #plasma
Cc: davidedmundson, ngraham, mvourlakos, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171212/ee5c1dd5/attachment.html>