D9281: Fix indentation of icon for left aligned toolbuttons

[Henrik Fehlauer]

rkflx created this revision.
rkflx added a reviewer: hpereiradacosta.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Gwenview's Operations sidebar uses custom `QToolButtons` which are
  wide and left aligned. Special support for this in Breeze was added with
  https://phabricator.kde.org/R31:2fb62271d777f7c5862576661252ecc3511c68f3. However with the transition to KF5 something broke: While
  the alignment to the left still worked, there was not enough space
  between the left button border and the icon:
  
  F5539728: 1_gwenview-toolbutton-margins_before.png <https://phabricator.kde.org/F5539728>
  
  This is fixed by adding the appropriate margin:
  
  F5539730: 2_gwenview-toolbutton-margins_after.png <https://phabricator.kde.org/F5539730>
  
  Note how this replicates exactly the spacing of the toolbuttons in the
  regular toolbar on the top (which had its icon size set to "small" in
  this screenshot).
  
  CCBUG: 381535

TEST PLAN
  Icons on toolbuttons in Gwenview's Operations sidebar no longer
  squished all the way to the left, text spacing still looking good.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9281

AFFECTED FILES
  kstyle/breezestyle.cpp

To: rkflx, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171210/26e876bf/attachment.html>