D8444: Define default Action when we plug unknown monitor

[Milian Wolff]

mwolff added a comment.


  In https://phabricator.kde.org/D8444#173635, @davidedmundson wrote:
  
  > I left a comment a month ago. It has not been addressed.
  >
  > > there's one part that's going to appear very confusing.
  >
  >
  >
  > > I have my (small) laptop. Lets say I want any new (big) screen to appear on the left. So I save "Extend to left".
  > > So I'd expect to see: monitor, laptop.
  >
  >
  >
  > > What will happen, is it will extend my biggest screen to the left, leaving me with:
  > > laptop, monitor
  >
  >
  >
  > > rendering the option seemingly broken.
  >
  > It's artbitrary depending on what size monitor you happen to plug in.
  
  
  I agree that this is broken, functionality-wise. But it was broken before too, right? So why was the old code looking up the biggest monitor and extending it, instead of using the primary one?

INLINE COMMENTS

> generator.cpp:328
>  
> -    Q_FOREACH(const KScreen::OutputPtr &output, connectedOutputs) {
> +    for (const KScreen::OutputPtr &output : qAsConst(connectedOutputs)) {
>          QSet<QSize> modeSizes;

this cleanup should happen in a separate patch

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D8444

To: mlaurent, davidedmundson
Cc: mwolff, sebas, graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171206/89ce9301/attachment.html>