D9196: Don't set a window icon for plasmashell

Eike Hein noreply at phabricator.kde.org
Tue Dec 5 11:42:24 UTC 2017


hein created this revision.
hein added reviewers: Plasma, davidedmundson, mart.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  Setting a window icon is surprisingly costly and a decent chunk of
  startup time. The shell doesn't need one. The only place I could
  find where this icon is visible is in the KSysguard process list :).
  
  Some people may be reminded of this rejected request:
  
  https://git.reviewboard.kde.org/r/128484/
  
  But that's Plasma::Dialog in plasma-framework, which (currently)
  still sets an icon. This is about the shell.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9196

AFFECTED FILES
  shell/main.cpp

To: hein, #plasma, davidedmundson, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171205/8b3c23b0/attachment-0001.html>


More information about the Plasma-devel mailing list