D9131: [comic] Destroy download dialog as time of applet

David Edmundson noreply at phabricator.kde.org
Mon Dec 4 09:35:59 UTC 2017


davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Personally I'd have just set a parent when creating the new KNS3::DownloadDialog.
  
  If someone ever did change this code so it deletes on close, the old code would have handled it, this won't.
  
  But this is also fine.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D9131

To: anthonyfieroni, davidedmundson, broulik
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171204/1a8805a9/attachment.html>


More information about the Plasma-devel mailing list