D9141: Setup QQmlEngine only once in QmlObject

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> mart wrote in qmlobject.h:72
> this shouldn't be necessary?
> 
> qmoobject will do things engine-wise, the qmlsharedengine subclass will always do things context-wise without new public constructors?

The problem being solved is that QQmlObjectSharedEngine inherits QQmlObject
that needs a constructor that doesn't do engine things

It could be protected though.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D9141

To: broulik, #plasma, mart
Cc: davidedmundson, hein, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171203/4c188426/attachment.html>