D9149: Allow running the tool without a display

Aleix Pol Gonzalez noreply at phabricator.kde.org
Sun Dec 3 17:06:51 UTC 2017


apol added inline comments.

INLINE COMMENTS

> krdb.cpp:141
> +  unsigned int pixmapDepth = 0;
> +  if (QApplication::primaryScreen() != nullptr)
> +    pixmapDepth = QPixmap::defaultDepth();

Are you sure this builds? `primaryScreen` isn't static.

I'd use `qGuiApp->primaryScreen()`.

> lnftool.cpp:37
>  {
> -    QApplication app(argc, argv);
> +    QCoreApplication app(argc, argv);
>  

Is this the same binary as above? If so, it should be `QGuiApplication` at least.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9149

To: adridg, #plasma, mart
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171203/cb6e7e1d/attachment.html>


More information about the Plasma-devel mailing list