D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign
Eike Hein
noreply at phabricator.kde.org
Sun Dec 3 11:54:12 UTC 2017
hein added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in main.qml:30-39
> My personal note is not mandatory but this piece of code can be seen 2 times in C++ part and 1 in QML. Can we add it on C++ part and called here too.
I hear you, but IMHO it's not really worth it to get inventive for some basic boilerplate. Down the line we just want generated code for this stuff (e.g. using KConfigXT more).
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8911
To: hein, #plasma, mart, abetts
Cc: anthonyfieroni, mmustac, ngraham, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171203/4d9a67d7/attachment.html>
More information about the Plasma-devel
mailing list