D9111: [IconItem] Use ItemSceneHasChanged rather than connect on windowChanged

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Saves a connection and also only schedule if we actually have a window

TEST PLAN
  `schedulePixmapUpdate` is now called 100 times on plasma startup for me instead of 120. Icons still looking fine. I'm not sure what the implications of calling `polish`, are especially without a window, but it's a slight optimization anyways as we make use of itemChange already

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9111

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171202/ca751a4f/attachment.html>