D8917: Reduce the amount of spurious property changes on ColorScope

David Edmundson noreply at phabricator.kde.org
Fri Dec 1 16:13:49 UTC 2017


davidedmundson added inline comments.

INLINE COMMENTS

> mart wrote in colorscope.cpp:193
> this is when the item changes window and we're not sure we are still in the same color set, so i think is ok to keep this signal

yeah, my point was we may /also/ need the colorsChanged signal (via checkColorGroupChanged)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D8917

To: apol, #plasma, mart, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171201/17c4a60b/attachment.html>


More information about the Plasma-devel mailing list