Fwd: Change in qt/qtbase[dev]: Make QPlatformServices as a separated plugin

[David Faure]

This might be of interest to some of you.

----------  Forwarded Message  ----------

Subject: Change in qt/qtbase[dev]: Make QPlatformServices as a separated 
plugin
Date: mardi 29 août 2017, 10:59:02 CEST
From: Jan Grulich (Code Review) <gerrit-noreply at qt-project.org>
To: David Faure <david.faure at kdab.com>
CC: Qt Sanity Bot <qt_sanitybot at qt-project.org>

Hello David Faure,

I'd like you to do a code review.  Please visit

    https://codereview.qt-project.org/202746

to review the following change.

Change subject: Make QPlatformServices as a separated plugin
......................................................................

Make QPlatformServices as a separated plugin

If one wants to reimplement QPlatformServices he has to reimplement
whole QPlatformIntegration plugin, which is not an easy task to do.
For this purpose we might want to make QPlatformServices as a standalone
plugin which can be specified additionally, like QPlatformTheme. This
patch allows to use custom QPlatformServices by providing parameter
"-platformservices" or additionally when you set QT_QPA_PLATFORM_SERVICES
variable.

Change-Id: Iaee0565aa75b4de2412d64ecb2d0b8d8d992aed3
---
M src/gui/kernel/kernel.pri
M src/gui/kernel/qguiapplication.cpp
M src/gui/kernel/qguiapplication_p.h
A src/gui/kernel/qplatformservicesfactory.cpp
A src/gui/kernel/qplatformservicesfactory_p.h
A src/gui/kernel/qplatformservicesplugin.cpp
A src/gui/kernel/qplatformservicesplugin.h
M src/gui/util/qdesktopservices.cpp
8 files changed, 368 insertions(+), 3 deletions(-)


  git pull ssh://codereview.qt-project.org:29418/qt/qtbase refs/changes/
46/202746/2
-- 
To view, visit https://codereview.qt-project.org/202746
To unsubscribe, visit https://codereview.qt-project.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaee0565aa75b4de2412d64ecb2d0b8d8d992aed3
Gerrit-PatchSet: 2
Gerrit-Project: qt/qtbase
Gerrit-Branch: dev
Gerrit-Owner: Jan Grulich <jgrulich at redhat.com>
Gerrit-Reviewer: David Faure <david.faure at kdab.com>
Gerrit-Reviewer: Friedemann Kleint <Friedemann.Kleint at qt.io>
Gerrit-Reviewer: Gunnar Sletta <gunnar at crimson.no>
Gerrit-Reviewer: Jani Heikkinen <jani.heikkinen at qt.io>
Gerrit-Reviewer: Paul Olav Tvete <paul.tvete at qt.io>
Gerrit-Reviewer: Qt Sanity Bot <qt_sanitybot at qt-project.org>
Gerrit-Reviewer: Samuel Rødal <srodal at gmail.com>

-----------------------------------------
-- 
David Faure | david.faure at kdab.com | Managing Director KDAB France
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53, http://www.kdab.fr
KDAB - The Qt, C++ and OpenGL Experts