D7567: Support edit and appstream actions also for application search results

[Kai Uwe Broulik]

broulik added a comment.


  Minor nitpicks, then it's good to go.

INLINE COMMENTS

> actionlist.cpp:322
> +
> +bool canEdit(const QString &entryPath)
> +{

canEditApplication

> actionlist.cpp:327
> +
> +void edit(const QString &entryPath, const QString &menuId)
> +{

editApplication

> runnermatchesmodel.cpp:128
> +            if (service->isApplication()) {
> +                actionList << Kicker::createSeparatorActionItem();
> +                actionList << Kicker::editApplicationAction(service);

You always add a separator at the end, so this isn't strictly neccessary (QMenu is smart enough to collapse double separators, though)

> backend.cpp:134
> +
> +    if (launcherUrl.isValid() && launcherUrl.scheme() == QStringLiteral("applications")) {
> +        const KService::Ptr service = KService::serviceByMenuId(launcherUrl.path());

Unrelated, from https://phabricator.kde.org/D7561?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7567

To: hein, #plasma, broulik, davidedmundson
Cc: mak, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170829/82d66f0b/attachment-0001.html>