D7561: Avoid absolute paths to .desktop files in launcher URLs.

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Thanks a lot! :)
  
  Verified that https://phabricator.kde.org/D7203 works well with it, even deleted the user-local desktop file at runtime and it immediately picked that up and didn't break \o/

INLINE COMMENTS

> tasktools.cpp:44
>  
> +#include <QDebug>
>  #include <QDir>

Unused

> tasktools.cpp:75
> +    // (i.e. .desktop file name) rather than the absolute path to a .desktop file.
> +    if (url.scheme() == QStringLiteral("applications")) {
> +        const KService::Ptr service = KService::serviceByMenuId(url.path());

compare with `QLatin1String`

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7561

To: hein, broulik, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170828/3b87add9/attachment.html>