D7537: KDE logout screen - change black icons & texts to white/greyish
Marco Martin
noreply at phabricator.kde.org
Fri Aug 25 13:32:55 UTC 2017
mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.
screenshots are necessary for visual changes
INLINE COMMENTS
> Logout.qml:140
> name: kuser.fullName
> +/* ColorOverlay {
> + anchors.fill: parent
remove dead code
> Logout.qml:170
> }
> + LogoutButton {
> + id: logoutButton
why is changing buttons order?
> Logout.qml:202
> + source: parent
> + color: "white"
> }
no hardcoded colors, ever, also on any theme that has colored icons (so anything but breeze) this will break
> Logout.qml:216
> }
> + color: "#c8c8c8"
> text: {
no hardcoded colors
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7537
To: pekkah, #plasma_workspaces, #plasma, #breeze, mart
Cc: mart, bshah, #breeze, pekkah, #plasma_workspaces, plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170825/15a7ecd2/attachment.html>
More information about the Plasma-devel
mailing list