D7515: Move updateXTime into the X11 standalone platform

Martin Flöser noreply at phabricator.kde.org
Thu Aug 24 15:00:25 UTC 2017


graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  KWin::updateXTime only delegates into the platform API where the method
  is a no-op. The actual implementation is moved into the X11 standalone
  platform as it uses QX11Info which is non functional except on the X11
  standalone platform.
  
  This change exposes a problem with timestamp handling: on Wayland the
  X11 timestamp does not get updated at all, causing e.g. window sync not
  work correctly (c.f. bug 374881). We cannot implement the updating in the
  same way as QX11Info/Qt xcb platform does it as that would introduce a
  blocking roundtrip to XWayland which is dangerous.
  
  As a side-effect this change removes linking to Qt5::X11Extras in kwin
  core as it's no longer needed.

REPOSITORY
  R108 KWin

BRANCH
  update-xtime-platform

REVISION DETAIL
  https://phabricator.kde.org/D7515

AFFECTED FILES
  CMakeLists.txt
  platform.cpp
  platform.h
  plugins/platforms/x11/standalone/x11_platform.cpp
  plugins/platforms/x11/standalone/x11_platform.h
  utils.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170824/8ac332d4/attachment-0001.html>


More information about the Plasma-devel mailing list