D7469: Use icon chooser in Kicker and Dashboard configuration to select custom icon

[Eike Hein]

hein added a comment.


  Can you also check the following case:
  
  1. Use the old UI to

INLINE COMMENTS

> ConfigGeneral.qml:123
> +                        cfg_useCustomButtonImage = false;
> +                        cfg_icon = "start-here-kde";
> +                    }

This isn't OK - it needs to revert to the actual config default. Some distros change it to their branded icon and are very keen on wanting to override specifically the default rather than pre-setting a deviation. That's one reason why the old config format had cfg_icon and otherwise used cfg_useCustomButtonImage (while your approach here is to migrate everyone to cfg_icon by setting cfg_useCustomButtonImage to false when the UI is used).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7469

To: dvratil, #plasma
Cc: hein, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170823/1f0a4e1d/attachment.html>