D7472: Don't elide UserDelegate text when there's only one item

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Aug 23 08:25:36 UTC 2017


broulik added inline comments.

INLINE COMMENTS

> UserDelegate.qml:141
>          text: wrapper.name
>          elide: Text.ElideRight
>          horizontalAlignment: Text.AlignHCenter

We could also just disable eliding and it will overflow?

> UserList.qml:80
> +        //if we only have one delegate, we don't need to clip the text as it won't be overlapping with anything
> +        constrainText: ListView.view.contentWidth > userItemWidth
> +

Just out of curiosity: why not `count`?

> UserList.qml:83
> +        Component.onCompleted: {
> +          console.log("DAVE", ListView.view.children)
> +        }

:D

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7472

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170823/e11a302f/attachment.html>


More information about the Plasma-devel mailing list