D7425: Add <number> to Wayland captions if the caption is the same

[Martin Flöser]

graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  Bringing another caption feature from X11 to Wayland. If we have
  multiple windows with the same caption, starting from the second window
  a suffix <number> is added.
  
  E.g. if we have three windows with caption "foo", the naming is:
  
  - foo
  - foo <2>
  - foo <3>
  
  The change tries to use as much shared code between the X11 and Wayland
  implementation. Unfortunately it's not possible to share completely as
  the X11 implementation does X11 specific things like editing the visible
  name.
  
  By sharing the code the numbering also works cross windowing system.
  That is if a window is called "foo" on X11, a new window on Wayland with
  caption "foo" will get adjusted to "foo <2>" and vice versa.
  
  The change also eliminates a duplicated signal for captionChanged in
  ShellClient (found by test case).
  
  By using the shared implementation on X11 side a bug gets fixed which
  got introduced with the support of "unresponsive", this is no longer
  considered and the numbering still works even if there is a window which
  is unresponsive.

TEST PLAN
  New test case and manual testing

REPOSITORY
  R108 KWin

BRANCH
  caption-numbering-wayland

REVISION DETAIL
  https://phabricator.kde.org/D7425

AFFECTED FILES
  abstract_client.cpp
  abstract_client.h
  autotests/integration/shell_client_test.cpp
  client.cpp
  client.h
  shell_client.cpp
  shell_client.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170820/3f8bc7ac/attachment.html>