D7359: Send output enter/leave events to surfaces
Martin Flöser
noreply at phabricator.kde.org
Thu Aug 17 04:30:43 UTC 2017
graesslin added a comment.
Overall looks good! It's way more self contained than I expected when first thinking about it.
INLINE COMMENTS
> test_helpers.cpp:110-113
> + QObject::connect(®istry, &Registry::outputAnnounced, [&](quint32 name, quint32 version) {
> + auto output = registry.createOutput(name, version, s_waylandConnection.compositor);
> + s_waylandConnection.outputs << output;
> + });
You also need to handle the outputRemoved. We have a few tests which add/remove Outputs.
> shell_client.cpp:1533
> + QVector<OutputInterface*> clientOutputs;
> + for(OutputInterface* output: waylandServer()->display()->outputs()) {
> + const QRect outputGeom(output->globalPosition(), output->pixelSize() / output->scale());
two minor comments here: qAsConst and a whitespace after for :-)
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D7359
To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170817/20481463/attachment-0001.html>
More information about the Plasma-devel
mailing list