D7331: Show UI for per screen scaling options on supported platforms

[Sebastian Kügler]

sebas accepted this revision.
sebas added a comment.
This revision is now accepted and ready to land.


  Nice! :)

INLINE COMMENTS

> outputconfig.h:71
>      QComboBox *mRotation;
> +    QComboBox *mScale;
>      QComboBox *mRefreshRate;

nullptr; ?
==========

The previous code didn't do this, but I think it's because it wasn't allowed in the C++ it was written in originally. I prefer to have these things initialized to nullptrs, mainly because I'm an idiot and want to make my own life easier. :)

> widget.h:94
>  
> +    QPushButton *mScaleAllOutputsButton;
>      QPushButton *mUnifyButton;

nullptr; please
===============

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7331

To: davidedmundson, sebas
Cc: sebas, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170815/0a451da4/attachment.html>