D7321: Collapse favorites sidebar when empty

David Edmundson noreply at phabricator.kde.org
Tue Aug 15 11:05:39 UTC 2017


davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> MenuRepresentation.qml:32
> +        + Math.max(units.gridUnit * 14, runnerColumns.width))
> +    Layout.maximumWidth: (sideBar.width + (sideBar.width ? mainRow.spacing : 0)
> +        + Math.max(units.gridUnit * 14, runnerColumns.width))

if this is the same as minimumWidth can you just bind to that, it's a bit faster and more readable

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7321

To: hein, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170815/2d8a90d2/attachment.html>


More information about the Plasma-devel mailing list