D7271: optionally show a history of notifications

Marco Martin noreply at phabricator.kde.org
Mon Aug 14 09:57:15 UTC 2017


mart added inline comments.

INLINE COMMENTS

> progwolff wrote in Notifications.qml:257
> It's almost the same. Only the models differ (NotificationsModel is used in NotificationDelegate, NotificationsHistoryModel is used in NotificationHistoryDelegate).
> 
> I also thought it might be a good idea to use a seperate delegates here, so that in the future history items might have a different visual representation than persistent notifications.
> 
> If this is not wanted, we could probably make the model a property of NotificationDelegate.

I don't think we would ever want a different visual representation for them, i would consider that a bug, as the thing looks quite busy already.

they can be the same file with just a different model property assigned

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7271

To: progwolff, #plasma, #vdg
Cc: mart, graesslin, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170814/fd34b945/attachment.html>


More information about the Plasma-devel mailing list