D7078: [server] Fix crash when sending selection to a DDI without a DataSource

[David Edmundson]

davidedmundson added a comment.


  > of course we do that :-)
  
  We're not.
  
  Kwin does not check if a client has a selection. 
  It merely checks if the client has an interface from a selection can be fetched, it does not check that device actually has a valid selection.
  
  > you think that we should not even send out the DataOffer I think that's a separate thing,
  
  No, that's not what I think.
  We're getting crosswired. I'll submit my coment as a patch, so maybe you'll understand what I'm trying to say.
  
  ---
  
  > Please note that I doubt that your suggestion would help against the crash I fixed here.
  
  If your patch works, then mine would too. It's checking the exact same pointer, just one frame earlier.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7078

To: graesslin, #kwin, #plasma, #frameworks
Cc: anthonyfieroni, davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170814/b286f197/attachment.html>