D7255: Remove application directory from QCoreApplication::libraryPaths()

[Fabian Vogt]

fvogt added a comment.


  In https://phabricator.kde.org/D7255#134745, @broulik wrote:
  
  > > I'll look whether it's possible to override that in a sane place as well.
  >
  > KDeclarative QmlObject, maybe? I think the single QuickViewSharedEngine used in most of Plasma should already give a significant improvement.
  
  
  I'd rather not change that in any framework, as applications linking to it can be deployed in whatever way they prefer.
  IMO it should be specified by the application itself.
  
  This diff to plasma-framework seems to work for some quick experiments (pun not intended) though:
  
    diff --git a/src/plasmaquick/appletquickitem.cpp b/src/plasmaquick/appletquickitem.cpp
    index 39facc613..29f0f7e69 100644
    --- a/src/plasmaquick/appletquickitem.cpp
    +++ b/src/plasmaquick/appletquickitem.cpp
    @@ -66,6 +66,12 @@ void AppletQuickItemPrivate::init()
             PackageUrlInterceptor *interceptor = new PackageUrlInterceptor(qmlObject->engine(), Plasma::Package());
             qmlObject->engine()->setUrlInterceptor(interceptor);
         }
    +
    +    // Remove the unnecessary applicationDirPath from the front of the import path list
    +    auto importPathList = qmlObject->engine()->importPathList();
    +    // Only set the import path if it actually changed, we might have removed it already.
    +    if (importPathList.removeAll(QCoreApplication::applicationDirPath()) > 0)
    +        qmlObject->engine()->setImportPathList(importPathList);
     }
     
     void AppletQuickItemPrivate::connectLayoutAttached(QObject *item)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7255

To: fvogt, #plasma
Cc: broulik, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170811/124894e1/attachment.html>