D7204: Use cached version isDir()

[David Edmundson]

davidedmundson added a comment.


  I would agree that we shouldn't be copying model data... But I'm not adding that, it's already there.
  
  > The FolderView::data() implementation already uses a cache
  
  It seems we only cache the result of .desktop files that point to remote URLs. The rest goes into KDirModel.
  
  A .desktop file to file:// stats every time.
  Any non .desktop file goes to whatever KDirModel does.
  
  FWIW, I'm working on the stuff here: 379994. 
  This doesn't actually fix anything there, the trace shows us doing an QFileInfo::isDir() but from a call to model.type

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7204

To: davidedmundson, mart
Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170808/5ad328b1/attachment.html>