D7207: Add virtual Scene::bufferPicture method

David Edmundson noreply at phabricator.kde.org
Tue Aug 8 18:20:09 UTC 2017


davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> scene.h:164
> +     **/
> +    virtual xcb_render_picture_t bufferPicture() const;
> +

IMHO, as this class is generic, yet the return type is very specific, the name should be reflect that and be
xrenderBufferPicture like effectsHandler has.

REPOSITORY
  R108 KWin

BRANCH
  scene-render-buffer

REVISION DETAIL
  https://phabricator.kde.org/D7207

To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170808/c3884d2c/attachment.html>


More information about the Plasma-devel mailing list