D7139: Fix QSortFilterProxyModelPrivate::updateChildrenMapping crash in libtaskmanager

[Eike Hein]

hein marked 3 inline comments as done.
hein added inline comments.

INLINE COMMENTS

> davidedmundson wrote in taskgroupingproxymodel.cpp:41
> Cleanup on destruction.
> 
> (which sounds like the name of a new Megadeth single)

Will do.

> davidedmundson wrote in taskgroupingproxymodel.cpp:465
> (I know this existing code)
> 
> why 1?
> shouldn't this should be currentSize + extraChildren.count()

This code is breaking a group apart, and this transaction specifically removes all the children from a group parent, leaving only the top-level item. In the row map this means an element QVector with only one element, hence it's resized to size 1.

> davidedmundson wrote in taskgroupingproxymodel.cpp:521
> I think we should assert after this if.

Will do.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7139

To: hein, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170804/c1c69de0/attachment.html>