D7089: [Breeze Style] Fix flickering during KPageTreeView animation

Hugo Pereira Da Costa noreply at phabricator.kde.org
Thu Aug 3 12:39:37 UTC 2017


hpereiradacosta added inline comments.

INLINE COMMENTS

> breezestyle.cpp:407
> +                pal.setColor( QPalette::Active, QPalette::Base, scrollArea->palette().color( scrollArea->backgroundRole() ) );
> +                scrollArea->setPalette(pal);
>              }

Setting palettes manually is always somewhat dangerous, (can break child widgets for instance, which would inherit this palette). 
Can we at least hide this code behind a check for QTreeView, and even "isAnimated()" ?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7089

To: broulik, #plasma, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170803/645e4236/attachment.html>


More information about the Plasma-devel mailing list