D7046: Use xcb-icccm to read the name property

Anthony Fieroni noreply at phabricator.kde.org
Wed Aug 2 06:44:14 UTC 2017


anthonyfieroni added inline comments.

INLINE COMMENTS

> fvogt wrote in client.cpp:1428
> Why not directly `QString::fromUtf8(reply.name, reply.name_len)` here? It would save one unnecessary copy. Alternatively, `QByteArray::fromRawData(reply.name, reply.name_len)`, but that's more verbose.

QByteArray has a move constructor, it's not copy.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7046

To: graesslin, #kwin, #plasma
Cc: anthonyfieroni, fvogt, broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170802/3a421ad3/attachment.html>


More information about the Plasma-devel mailing list