D7035: Fix group dialog no longer resizing/closing as windows are closed and the group is dissolved

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Aug 1 13:13:39 UTC 2017


broulik added inline comments.

INLINE COMMENTS

> GroupDialog.qml:138
>                      property bool aboutToPopulate: false
> +                    property int oldCount: 0
>  

Unused

> GroupDialog.qml:153
> +                    onItemRemoved: {
> +                        if (groupDialog.visible && index > 0 && index == count) {
> +                            updateSize();

`count` will already reflect the new count here? So essentially `index == count` means "the last item was removed"?

> TaskList.qml:23
>  Flow {
> +    id: taskList
> +

Unused?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7035

To: hein, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170801/5884105d/attachment.html>


More information about the Plasma-devel mailing list