D5568: SFTP ioslave: Port away from KDELibs4Support

David Faure noreply at phabricator.kde.org
Sun Apr 30 14:46:39 UTC 2017

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.


> kio_sftp.cpp:836
>          // Handle user canceled or dialog failed to open...
> -        if (!openPasswordDialog(info, errMsg)) {
> +        if (openPasswordDialogV2(info, errMsg) != 0) {
>            qCDebug(KIO_SFTP_LOG) << "User canceled password/retry dialog";

This should store the return value from openPasswordDialogV2 and use it in the error call 3 lines below, that's the whole point of the port to V2.

Same for the calls above, if possible (the patch doesn't show what the error handling is).

  R320 KIO Extras


To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170430/ef3c84e8/attachment.html>

More information about the Plasma-devel mailing list