D5618: Revert "launch autostart apps in ksmserver using KRun, not QProcess"KRun::runApplication will show blocking error dialogs if it fails to find the executableThis means we don't autostart the next app, which could be fatal if it comes before...

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  ...kwin/plasma
  We shouldn't be having blocking calls in ksmserver it can deadlock
  And even in the best case we'd still end up blocking ksplash for 30 seconds
  
  We then port to KProcess which was part of the motivation behind the patch as it
  has better stdout handling
  
  This reverts commit https://phabricator.kde.org/R120:0f19e92f3e85d064de9cebf280fa8e085485c2e0.
  
  BUG: 379254
  
  Port autostarting applications to KProcess
  It has better stdout handling

TEST PLAN
  Logged in, still got my main session

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D5618

AFFECTED FILES
  ksmserver/startup.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170427/cb8fb3e0/attachment.html>