D5612: [Notification Jobs] Enforce plain text and escape HTML

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Apr 27 10:22:05 UTC 2017


broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  QtQuick Text auto-interprets HTML tags when it finds them, this can lead to unexpected results if a file is named e.g. `<h1>foo</h1>`.
  
  Since notifications do interpret HTML tags by design, we manually escape them there.

TEST PLAN
  Copied a file `<h1>foo</h1>` and no longer got huge text in summary, details, and finish popup. Verified that speed and ETA label still works.
  
  5.8 branch?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5612

AFFECTED FILES
  applets/notifications/package/contents/ui/JobDelegate.qml
  applets/notifications/package/contents/ui/JobDetailsItem.qml
  applets/notifications/package/contents/ui/Jobs.qml

To: broulik, #plasma
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170427/67260531/attachment-0001.html>


More information about the Plasma-devel mailing list