D5538: Implement QPlatformTheme::fileIconPixmap()

Mark Gaiser noreply at phabricator.kde.org
Fri Apr 21 14:26:21 UTC 2017

markg added a comment.

  It pains me a bit to say this since it looks like you've spend quite a bit of time writing that code.
  But please do look at KIO::iconNameForUrl [1] (like also suggested by Kai on reviewboard). Much of the code can likely be replaced by just using that instead.
  [1] https://api.kde.org/frameworks/kio/html/namespaceKIO.html#a215707adb0153b5ba4b318785fc746ea

  R135 Integration for Qt applications in Plasma


To: eshalygin, #plasma
Cc: markg, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170421/790dc95f/attachment.html>

More information about the Plasma-devel mailing list