Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

[Eugene Shalygin]

> On April 21, 2017, 11:12 a.m., Kai Uwe Broulik wrote:
> > src/platformtheme/kdeplatformtheme.cpp, line 122
> > <https://git.reviewboard.kde.org/r/130094/diff/1/?file=494561#file494561line122>
> >
> >     Why is this only built in 5.7 and below? Was this removed in 5.8? (didn't check Qt code)
> 
> Eugene Shalygin wrote:
>     Signature of the function was changed in 5.8 if you are asking about the #ifdef. Did I understand you correctly?
> 
> Kai Uwe Broulik wrote:
>     Yep, that's what I've been asking. So, there's no method returning a QIcon anymore? Pity.

No, quite the opposite: there was no method returning QIcon before 5.8.


- Eugene


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130094/#review103073
-----------------------------------------------------------


On April 21, 2017, 11:11 a.m., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130094/
> -----------------------------------------------------------
> 
> (Updated April 21, 2017, 11:11 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-integration
> 
> 
> Description
> -------
> 
> Implement QPlatformTheme::fileIconPixmap() to make QFileIconProvider work.
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/kdeplatformtheme.h 7835439 
>   src/platformtheme/kdeplatformtheme.cpp 704f176 
> 
> Diff: https://git.reviewboard.kde.org/r/130094/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170421/f63ce284/attachment-0001.html>