Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

[Eugene Shalygin]

> On April 21, 2017, 11:01 a.m., Mark Gaiser wrote:
> > src/platformtheme/kdeplatformtheme.cpp, line 422
> > <https://git.reviewboard.kde.org/r/130094/diff/1/?file=494561#file494561line422>
> >
> >     foreach OR for (... : qAsConst(m_standardPathItems))
> >     Or use std::vector and keep the for as is..
> >     
> >     qAsConst is in Qt since 5.7 so i think that's a bit to new to use.

Went with std::vector


- Eugene


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130094/#review103072
-----------------------------------------------------------


On April 21, 2017, 11:11 a.m., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130094/
> -----------------------------------------------------------
> 
> (Updated April 21, 2017, 11:11 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-integration
> 
> 
> Description
> -------
> 
> Implement QPlatformTheme::fileIconPixmap() to make QFileIconProvider work.
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/kdeplatformtheme.h 7835439 
>   src/platformtheme/kdeplatformtheme.cpp 704f176 
> 
> Diff: https://git.reviewboard.kde.org/r/130094/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170421/554ba427/attachment-0001.html>