D5504: Introduce a HasLauncher data role.

[David Edmundson]

davidedmundson added a comment.


  appsMatch depends on AppId and LauncherURLWithoutIcon
  
  You're handling launcherTasksModel changing, but can we rely on this data being static for a proxyIndex?
  
  If not, we need to connect to TasksModel::dataChanged for those roles and potentially then emit that HasLauncher changed.
  
  -----
  
  Having read your other patch you could argue that you don't need to signal this role as you (currently) only use this role from method calls triggered by other events....but if you take that POV, there's no point doing the launcherListChanged connect.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5504

To: hein, #plasma, davidedmundson
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170419/df2357cc/attachment.html>